-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #6954 - Add additions that allow Foreman tests to pass. #4534
Conversation
Will require - theforeman/foreman#1849 |
[test] |
[test] now that the Foreman side is merged. EDIT: dang, page refresh failed to show your test @ehelms. nevermind then :) |
d8bff1d
to
0e24081
Compare
2789e44
to
af37bc2
Compare
Foreman allows a plugin to provide a file to be loaded during their test runs. Here we address: * Dynflow transaction issues due to using hooks on extended Foreman models Further, Foreman has added the ability to skip core Foreman tests that cannot pass in the context of a particular plugin. In Katello's case we skip: * Tests related to nested orgs and locations * Tests that save a user due to our AR hooks + dynflow orchestration
8becfdb
to
de9bfb2
Compare
Just curious to see the failures, the previous test results were purged [test] |
If you want to see this run, with Foreman core tests, you'll want to run http://ci.theforeman.org/job/test_katello_core_gsutcliffe/ because our current job doesn't run in this context currently. |
As part of this as well, I have been working on making re-usable tasks in the core that plugins can take advantage of as well as run combinations of tests: theforeman/foreman#2571 |
theforeman/foreman#3056 should make this work 😄 although I really hate this hack. I'd prefer if you found a way for doing this without changing behaviour, as plugins should add behaviour, not change it. |
@ehelms theforeman/foreman#3056 is merged, mind giving this a rebase? |
@ehelms is this still needed? I am not sure of the context of this PR |
@beav this is something that would be nice for me to finish, all other plugins run their own tests and all Foreman unit tests combined to verify whether they are breaking core functionality or at least intentionally skipping over it. |
Foreman allows a plugin to provide a file to be loaded during their
test runs. Here we address:
models