Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #6954 - Add additions that allow Foreman tests to pass. #4534

Closed
wants to merge 1 commit into from

Conversation

ehelms
Copy link
Member

@ehelms ehelms commented Aug 6, 2014

Foreman allows a plugin to provide a file to be loaded during their
test runs. Here we address:

  • Dynflow transaction issues due to using hooks on extended Foreman
    models

@ehelms
Copy link
Member Author

ehelms commented Oct 13, 2014

Will require - theforeman/foreman#1849
With the above required change in Foreman, a setup with Foreman and Katello should now be able to run rake test to run all of the Foreman tests and have them pass in the context of Katello.

@ehelms ehelms changed the title [WIP] Fixes #6954 - Add additions that allow Foreman tests to pass. Fixes #6954 - Add additions that allow Foreman tests to pass. Oct 13, 2014
@ehelms
Copy link
Member Author

ehelms commented Oct 20, 2014

[test]

@GregSutcliffe
Copy link
Contributor

[test] now that the Foreman side is merged.

EDIT: dang, page refresh failed to show your test @ehelms. nevermind then :)

Foreman allows a plugin to provide a file to be loaded during their
test runs. Here we address:

 * Dynflow transaction issues due to using hooks on extended Foreman
   models

Further, Foreman has added the ability to skip core Foreman tests that
cannot pass in the context of a particular plugin. In Katello's case
we skip:

 * Tests related to nested orgs and locations
 * Tests that save a user due to our AR hooks + dynflow orchestration
@stbenjam
Copy link
Contributor

Just curious to see the failures, the previous test results were purged

[test]

@ehelms
Copy link
Member Author

ehelms commented Aug 24, 2015

If you want to see this run, with Foreman core tests, you'll want to run http://ci.theforeman.org/job/test_katello_core_gsutcliffe/ because our current job doesn't run in this context currently.

@ehelms
Copy link
Member Author

ehelms commented Aug 24, 2015

As part of this as well, I have been working on making re-usable tasks in the core that plugins can take advantage of as well as run combinations of tests: theforeman/foreman#2571

@unorthodoxgeek
Copy link

theforeman/foreman#3056 should make this work 😄

although I really hate this hack. I'd prefer if you found a way for doing this without changing behaviour, as plugins should add behaviour, not change it.

@beav
Copy link
Contributor

beav commented Feb 15, 2016

@ehelms theforeman/foreman#3056 is merged, mind giving this a rebase?

@beav
Copy link
Contributor

beav commented Oct 10, 2016

@ehelms is this still needed? I am not sure of the context of this PR

@ehelms
Copy link
Member Author

ehelms commented Oct 13, 2016

@beav this is something that would be nice for me to finish, all other plugins run their own tests and all Foreman unit tests combined to verify whether they are breaking core functionality or at least intentionally skipping over it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants