Fixes #8570: Show modal dialog before deletion. #5053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehelms
added
Needs Backporting
Needs testing
Not yet reviewed
and removed
Needs testing
Not yet reviewed
labels
| @@ -25,8 +25,13 @@ <h3 translate>Packages in {{ repository.name }}</h3> | |||
| </div> | |||
|
|
|||
| <div data-block="actions"> | |||
| <div bst-modal="removeContent()"> | |||
| <div data-block="modal-header" translate>Remove {{ detailsTable.numSelected }} Packages?</div> | |||
| <div data-block="modal-body" translate>Are you sure you want to remove the {{ detailsTable.numSelected }} packages selected?</div> | |||
There was a problem hiding this comment.
For these do we need to use the plural feature that translate gives us? Its annoying to use, but it makes it look much better than seeing '1 packages'
theforeman-bot
added
Needs testing
Needs re-review
and removed
Waiting on contributor
labels
|
Updated |
|
LGTM |
| @@ -25,8 +25,13 @@ <h3 translate>Packages in {{ repository.name }}</h3> | |||
| </div> | |||
|
|
|||
| <div data-block="actions"> | |||
| <div bst-modal="removeContent()"> | |||
| <div data-block="modal-header" translate-plural>Remove {{ detailsTable.numSelected }} Packages?</div> | |||
| <div data-block="modal-body" translate-plural>Are you sure you want to remove the {{ detailsTable.numSelected }} packages selected?</div> | |||
There was a problem hiding this comment.
Is this the right way to use translate-plural? All the other examples in the code are quite a bit more verbose and specific.
There was a problem hiding this comment.
No, it's not.
You need to provide translate-n so it knows whether or not to use the plural and `translate-plural' should have the plural message, see the docs.
| @@ -26,8 +26,22 @@ <h3 translate>Docker Images in {{ repository.name }}</h3> | |||
| </div> | |||
|
|
|||
| <div data-block="actions"> | |||
| <div bst-modal="removeContent()"> | |||
| <div data-block="modal-header" | |||
| translate-plural | |||
There was a problem hiding this comment.
This extra directive is unneeded right?
|
ack |
ehelms
added a commit
that referenced
this pull request
Mar 11, 2015
Fixes #8570: Show modal dialog before deletion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.