Fixes #10622 - Fixes javascript traceback when removing repositories #5261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| angular.forEach(response.task.input.target_ids, function (row) { | ||
| $scope.repositoriesTable.removeRow(row); | ||
| }); | ||
| $scope.successMessages.push("Initiated removal of selected repositories, see task " + response.task.id + " for details."); |
There was a problem hiding this comment.
What about linking to this task directly in the success message? We do something similar here.
|
@adamruzicka: LGTM, can you please squash those commits into one and I think we'll be good to go. |
adamruzicka
force-pushed
the
10622-repository_delete_traceback
branch
from
76faebb
to
b5d92ff
Compare
|
@waldenraines squashed, thank you |
waldenraines
pushed a commit
that referenced
this pull request
Jun 2, 2015
…ceback Fixes #10622 - Fixes javascript traceback when removing repositories
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.