Fixes #11295 Sync dates compensate for timezone #5400
Conversation
|
In the original version, what is actually sent to the server? Does that include timezone information that isn't being correctly handled by the server? |
|
The sync date is composed in two parts; the desired date and then the desired time. When the user enters the desired date it is captured with a time of 00:00:00. This date is then passed to a constructor that offsets the date according to the timezone and therefore may actually push the date backwards. |
|
Do you think we could craft a test to ensure this outputs properly in the future? |
| @@ -44,7 +44,8 @@ angular.module('Bastion.sync-plans').controller('NewSyncPlanController', | |||
| } | |||
|
|
|||
| $scope.createSyncPlan = function (syncPlan) { | |||
| var syncDate = new Date(syncPlan.startDate), | |||
| var syncDate = new Date(syncPlan.startDate.getTime() + | |||
| syncPlan.startDate.getTimezoneOffset() * 60000), | |||
There was a problem hiding this comment.
You may want to create a variable (or better yet a const) for the 60,000 so it is immediately clear what it represents, i.e.: const HOURS_IN_DAY = 24;
|
Thanks for the PR and good catch.
Agreed, you will have to fix the existing test(s) anyway so you should also ensure this is tested. When committing code that alters bastion or bastion_katello it is good practice to run |
To ensure the correct date is saved per the user's input adjust the date to account for timezone difference
|
ACK |
Fixes #11295 Sync dates compensate for timezone
To ensure the correct date is saved per the user's input
adjust the date to account for timezone difference