fixes #12397 - properly detect pulp task failures again #5567
Conversation
|
@iNecas curious about your thoughts on this, i believe it was caused by this change: Dynflow/dynflow@6f56df9#diff-15e875d53193085cf195d9fe4e81e5b2R84 wanted to make sure this i the right place to add this check, as it worked fine before but now treats these exceptions as 'failed polls' |
jlsherrill
changed the title
|
I'm not sure this change really helps, as the |
|
@iNecas at that commit https://github.com/Dynflow/dynflow/blob/master/lib/dynflow/action/polling.rb#L28 Overriding rescue_poll_external_task is an option, id' rather not have to reproduce all of that logic, but it seems like a better place than sticking the exception in done?. Will give that a try. |
|
@jlsherrill right, this works then… :) 👍 |
|
ACK |
fixes #12397 - properly detect pulp task failures again
The root cause of this is that this commit: Katello#5567 made it so that resume_external_action no longer threw an exception. Due to a recent change in dynflow it is needed to throw an exception in the case of a non-network error. So this change returns the functionality of checking for pulp task errors on polling, but overrides poll_external_task_with_rescue to not treat pulp errors as poll errors. Conflicts: app/lib/actions/pulp/abstract_async_task.rb
The root cause of this is that this commit: Katello#5567 made it so that resume_external_action no longer threw an exception. Due to a recent change in dynflow it is needed to throw an exception in the case of a non-network error. So this change returns the functionality of checking for pulp task errors on polling, but overrides poll_external_task_with_rescue to not treat pulp errors as poll errors.
The root cause of this is that this commit: #5567 made it so that resume_external_action no longer threw an exception. Due to a recent change in dynflow it is needed to throw an exception in the case of a non-network error. So this change returns the functionality of checking for pulp task errors on polling, but overrides poll_external_task_with_rescue to not treat pulp errors as poll errors. Conflicts: app/lib/actions/pulp/abstract_async_task.rb
The root cause of this is that this commit: Katello#5567 made it so that resume_external_action no longer threw an exception. Due to a recent change in dynflow it is needed to throw an exception in the case of a non-network error. So this change returns the functionality of checking for pulp task errors on polling, but overrides poll_external_task_with_rescue to not treat pulp errors as poll errors. (cherry picked from commit 86de639)
No description provided.