Fixes #15545: use bastion nutupane panel loading spinner #6158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Requires Katello/bastion#115. |
|
Should I still see the world loading on pages that use nutupane details tables? I only see the spinner. |
theforeman-bot
added
Needs testing
Needs re-review
and removed
Waiting on contributor
labels
We discussed this over IRC but for everyone else's benefit the spinner only behavior was there before this PR and is not affected by it. I believe this comes from the tables whereas the spinner in this PR is only shown when the parent details page shows initially. |
Ensure that all details pages are using the bastion nutupane panel loading spinner. http://projects.theforeman.org/issues/15545
|
ACK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that all details pages are using the bastion nutupane
panel loading spinner.
http://projects.theforeman.org/issues/15545