Fixes #18459: fix incremental update select content host display #6605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rebase needed here |
The next and cancel buttons for incremental update were being displayed below the table and if there were a lot of content hosts the user would have to scroll through the entire list of content hosts (due to infinite scrolling) in order to get to the buttons. This commit temporarily moves the next/cancel buttons to the top of the table until this entire workflow can be replaced by the angular-patternfly wizard. http://projects.theforeman.org/issues/18459
@ehelms fixed. |
|
This just seems weird to me: although, i can't think of any alternative as long as we're on infinite scroll. Could we file an issue to move this back down once we add real pagination? |
|
|
ACK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The next and cancel buttons for incremental update were being displayed
below the table and if there were a lot of content hosts the user would
have to scroll through the entire list of content hosts (due to infinite
scrolling) in order to get to the buttons. This commit temporarily
moves the next/cancel buttons to the top of the table until this entire
workflow can be replaced by the angular-patternfly wizard.
http://projects.theforeman.org/issues/18459