Fixes #21484 - Auto complete for Docker Meta Tag #7040
Conversation
This commit adds autocomplete constructs to docker meta tag and removes the unused ones in docker tag. Idea here is DockerTagsController has now completely shifted to using the DockerMetaTag model for all data purposes and hence there is no value in holding auto complete constructs there. This commit also includes sensible auto complete values for docker manifests so that one can search by things like the manifest's digest name and schema version in the Repository -> Manage Docker Manifests page.
|
Issues: #21484 |
|
To test this PR
|
|
Also note you can search only for '=' in case of schema_version of a DockerMetaTag |
| @@ -9,6 +9,8 @@ class DockerManifest < Katello::Model | |||
| CONTENT_TYPE = Pulp::DockerManifest::CONTENT_TYPE | |||
| scoped_search :on => :name, :complete_value => true | |||
| scoped_search :relation => :docker_tags, :on => :name, :rename => :tag, :complete_value => true, :only_explicit => true | |||
| scoped_search :on => :digest, :rename => :digest, :complete_value => true, :only_explicit => true | |||
| scoped_search :on => :schema_version, :rename => :schema_version, :complete_value => true, :only_explicit => true | |||
There was a problem hiding this comment.
Both of these new searches are using only_explicit: true and I point that out because I think you'll have an upcoming PR which removes the name field from DockerManifest which means that all of the scoped search fields are only_explicit: true.
My question is: after removal of the name field, which, if any field should become only_explicit: false and should we make it that way at this time?
There was a problem hiding this comment.
Hmm good point I can see search by tag name being an automatic thing. That being said I would like to keep it the way it is in this PR because downstream will want what is here.
This commit adds autocomplete constructs to docker meta tag and removes
the unused ones in docker tag. Idea here is DockerTagsController has now
completely shifted to using the DockerMetaTag model for all data
purposes and hence there is no value in holding auto complete
constructs there.
This commit also includes sensible auto complete values for docker
manifests so that one can search by things like the manifest's digest
name and schema version in the Repository -> Manage Docker Manifests
page.