Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #22276 - Make errata apply via REX respond #7152

Merged
merged 1 commit into from
Jan 25, 2018

Conversation

jturel
Copy link
Member

@jturel jturel commented Jan 15, 2018

Clicking the apply button wasn't submitting the form from the content host Errata tab. The form I moved was not in the DOM at all.

I think it was because something changed in table.html or the plugin which enables data-extend-template and we were not specifying a data-block which made it be ignored. I checked other forms using the remote_execution action and we should be good. It's now consistent with

<form id="traceActionForm" method="post" action="/katello/remote_execution">

You'll see the task is now created. If you want to end-to-end test you'll need to configure your environment with the REX plugin. Can provide the details if you want to embark on that. I was able to apply errata successfully.

@theforeman-bot
Copy link

Issues: #22276

@jlsherrill
Copy link
Member

[test rails-5]

1 similar comment
@jturel
Copy link
Member Author

jturel commented Jan 24, 2018

[test rails-5]

Copy link
Member

@jlsherrill jlsherrill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@jturel jturel merged commit f376158 into Katello:master Jan 25, 2018
@jturel jturel deleted the bug22276 branch January 25, 2018 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants