Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refs #23190 - replace .uniq with .distinct #7308

Merged
merged 1 commit into from Apr 16, 2018

Conversation

jlsherrill
Copy link
Member

No description provided.

@theforeman-bot
Copy link

Issues: #23190

@jlsherrill jlsherrill changed the title Thomasmckay 23190 distinct Refs #23190 - replace .uniq with .distinct Apr 12, 2018
@@ -353,16 +353,6 @@ def products(env = nil)
Product.joins(:repositories).where("#{Katello::Repository.table_name}.id" => repos.map(&:id)).distinct
end

def version_products(env)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dead code I guess?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep!

@jturel jturel self-assigned this Apr 12, 2018
@jlsherrill
Copy link
Member Author

[test katello]

2 similar comments
@jlsherrill
Copy link
Member Author

[test katello]

@jlsherrill
Copy link
Member Author

[test katello]

Copy link
Member

@jturel jturel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the tests! APJ

@jlsherrill jlsherrill merged commit 542a00c into Katello:master Apr 16, 2018
@jlsherrill jlsherrill deleted the thomasmckay-23190-distinct branch April 16, 2018 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants