Fixes #26686 - Pulp3 changed contents #8097
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 9fe5a36757e60017ff376aad52ae550203a6a76f)
|
Issues: #26686 |
sjha4
commented
May 1, 2019
| @@ -14,7 +14,6 @@ def invoke_external_task | |||
| end | |||
|
|
|||
| def external_task=(tasks) | |||
| output[:contents_changed] = false | |||
| output[:create_version] = true | |||
| super | |||
| end | |||
There was a problem hiding this comment.
We don't need this anymore. Will remove after tests are run.
sjha4
commented
May 1, 2019
| create_distribution(prefix, path) if repo.root.unprotected | ||
| else | ||
| create_distribution(prefix, path) | ||
| end | ||
| end |
There was a problem hiding this comment.
Copied from @jjeffers update PR since there were issues with the distribution creation.
|
Cherry-picked in #8123. Closing.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a pulp3 sync, we get a new version href from pulp3. We want to check in the new version created if any new content was added. Based on that we save the version, create new publication and refresh distribution.
The same contents_changed is passed to index action to either run or skip indexing.
To do: