Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #27037 - update proxy task #8163

Merged
merged 16 commits into from
Jun 25, 2019
Merged

Fixes #27037 - update proxy task #8163

merged 16 commits into from
Jun 25, 2019

Conversation

jjeffers
Copy link
Member

@jjeffers jjeffers commented Jun 13, 2019 •
edited
Loading

This PR creates a new rake task for katello. The task "update_default_http_proxy" takes a http proxy name as defined under the Infrastructure->Http Proxies.

Example:

[vagrant@centos7-katello-devel foreman]$ bundle exec rails katello:update_default_http_proxy -- -n a_new_proxy -u http://192.168.23.131 -s admin -p redhat
...
Content default http proxy set to a_new_proxy (http://192.168.23.131).

@theforeman-bot
Copy link

Issues: #23037

@jjeffers jjeffers marked this pull request as ready for review June 17, 2019 15:18
@jjeffers
Copy link
Member Author

[test katello]

@theforeman-bot
Copy link

There were the following issues with the commit message:

  • ebba0a2 must be in the format fixes #redmine_number - brief description

If you don't have a ticket number, please create an issue in Redmine.

More guidelines are available in Coding Standards or on the Foreman wiki.

This message was auto-generated by Foreman's prprocessor

@jlsherrill
Copy link
Member

One last comment, but then i think this is good!

@jlsherrill jlsherrill changed the title 27037 update proxy task Fixes #27037 - update proxy task Jun 21, 2019
jlsherrill
jlsherrill approved these changes Jun 24, 2019
View reviewed changes
Copy link
Member

@jlsherrill jlsherrill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APJ!

@jjeffers
Copy link
Member Author

[test katello]

2 similar comments
@jlsherrill
Copy link
Member

[test katello]

@jjeffers
Copy link
Member Author

[test katello]

@jjeffers jjeffers merged commit 730ba5e into Katello:master Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlsherrill jlsherrill jlsherrill approved these changes

Assignees
No one assigned
Labels
Needs testing Not yet reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jjeffers @theforeman-bot @jlsherrill