Fixes #29260 - Add -y flag for yum command #8599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Katello Ansible default action using yum with ansible shell command were missing a -y flag which made them hang when used on a host
|
Can one of the admins verify this patch? |
|
Issues: #29260 |
|
👍 question for katello maintainers - is there a sync script that would automate this? should we drop templates from this repo and start seeding it from community templates? templates can contain requirements from now, so they wouldn't be seeded if Katello is not available |
|
@ares we don't have any processes right now in Katello for keeping the job templates in this repo synced with the community templates. I agree that it would be better to either add a way to sync or start having Katello seed from the community templates. I will make an issue on redmine about it. |
ianballou
approved these changes
Mar 9, 2020
|
[test katello] |
jjeffers
pushed a commit
to jjeffers/katello
that referenced
this pull request
May 20, 2020
The Katello Ansible default action using yum with ansible shell command were missing a -y flag which made them hang when used on a host (cherry picked from commit 21bffba)
jjeffers
pushed a commit
that referenced
this pull request
May 22, 2020
The Katello Ansible default action using yum with ansible shell command were missing a -y flag which made them hang when used on a host (cherry picked from commit 21bffba)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
As described in : https://projects.theforeman.org/issues/29260
And https://community.theforeman.org/t/using-sudo-su-for-privilege-escalation/17635/4
The Katello Ansible Default templates that are using Ansible shell commands directly for creating Yum action like update are missing a "-y" flag which makes them hang
This fixes the problem by adding the missing -y flag on each template that was missing it.