Fixes #29768 - Use debversion extension for sorting deb-versions

[m-bucher]

This requires that rh-postgresql12-postgresql-debversion package is installed.
Additionally the extension must be activated in the database:

CREATE EXTENSION debversion;

Not sure if this can/should be done in the migration-script.

Having this merged would make it possible to merge/review #7961 and #8277, because they rely on a possibility to compare Debian version numbers.

[m-bucher]

OK, so the test fails because db/schema.rb is not correctly created:

# Could not dump table "katello_debs" because of following StandardError
#   Unknown type 'debversion' for column 'version_sortable'

Any ideas?

[m-bucher]

Patched the debversion into the PostgreSQLAdapter 😁

[chris1984]

@m-bucher what are the steps for me to test this? Just install the package and run a db:migrate/seed?

[m-bucher]

@chris1984 yes, if the postgresql-debversion package is installed, the migration should work.

[chris1984]

Awesome will test it Monday

[chris1984]

@m-bucher

To testing the sorting, do I just need to upload a few deb packages of different names, or the same name but with different versions?

[m-bucher]

@chris1984, either that or you just sync any apt-repository (I do not recommend Debian stable repository because it is fairly large 😁 ).
Something like Ubuntu focal-security should have a reasonable size, because it is fairly new:

URL	Release	Architecture
http://archive.ubuntu.com/ubuntu/	focal-security	amd64

Then you can compare the results of ORDER BY version and ORDER BY version_sortable in the DB-console.
At least that's what I did 😃

[chris1984]

ACK looks good to me based on the results being different:

                    name                     |            version             
---------------------------------------------+--------------------------------
 libjson-c-dev                               | 0.13.1+dfsg-7ubuntu0.2
 libjson-c4                                  | 0.13.1+dfsg-7ubuntu0.2
 libjson-c-doc                               | 0.13.1+dfsg-7ubuntu0.2
 libexif-doc                                 | 0.6.21-6ubuntu0.1
 libexif-dev                                 | 0.6.21-6ubuntu0.1
 libexif12                                   | 0.6.21-6ubuntu0.1


katello=# select name, version from katello_debs ORDER by version_sortable;
                    name                     |            version             
---------------------------------------------+--------------------------------
 libexif-doc                                 | 0.6.21-6ubuntu0.1
 libexif12                                   | 0.6.21-6ubuntu0.1
 libexif-dev                                 | 0.6.21-6ubuntu0.1
 libjson-c-dev                               | 0.13.1+dfsg-7ubuntu0.2
 libjson-c4                                  | 0.13.1+dfsg-7ubuntu0.2
 libjson-c-doc                               | 0.13.1+dfsg-7ubuntu0.2

@jturel any comments?

[jlsherrill]

This looks good to me, just waiting on https://github.com/theforeman/puppet-katello/pull/341/files so we don't break nightlies

[jlsherrill]

I think this is good to go. Thanks @m-bucher !