Fixes #30224 - Add module filtering #8822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #30224 |
|
After brief chat with Partha, this is the right feature set to test with : https://gitlab.com/2020-summit-labs/hands-on-with-satellite-6.7/-/blob/master/workshop/content/content-view-filters.adoc .. Working on testing and implementing missing pieces. |
|
Updated to include changes for include/exclude all moduled without errata and errata based filtering. Should be ready to test for modular/package filters.. |
ianballou
reviewed
Jul 27, 2020
There was a problem hiding this comment.
I think modular rpms are being filtered out where they shouldn't be. My test:
- Sync modules-rpms (https://partha.fedorapeople.org/test-repos/separated/modules-rpms/) and rpm-deps (https://partha.fedorapeople.org/test-repos/separated/rpm-deps/)
- Stick them both in a CV
- Make a package filter and exclude
* - See that all content is filtered out. Only the non-modular RPMs should get filtered out.
-> Results in the CVV should be:walrus-0.71andwalrus-5.21, their module streams (2 total), and theWALRUS-2013:0002erratum.
Side note: On the filter, if you select "Show matching content", only the non-modular RPMs show up, but more are actually filtered out.
ianballou
reviewed
Jul 28, 2020
There was a problem hiding this comment.
The include filter has been working, but I'm having troubles with the exclude filter. If I exclude certain versions of postgresql or nodejs from the RHEL 8 AppStream repo, all of the module streams disappear. My content view also has the needed-errata, modules-rpms, and rpm-deps repos.
|
Think I addressed the issues in the comments. Looking at the conflicts here. We need pulp_rpm 3.5 for this and 3.5 pulp_rpm gem with this. |
sjha4
changed the title
|
I'm hitting an error when filtering the RHEL 8 AppStream repo. I don't think it's directly related to your PR, but rather the upgrade to Pulp RPM 3.5.0. Stack trace: |
ianballou
reviewed
Aug 4, 2020
sjha4
force-pushed
the
module_filters
branch
2 times, most recently
from
e28d4ff
to
79fb1dd
Compare
(cherry picked from commit e28d4ff)
ianballou
reviewed
Aug 5, 2020
ianballou
pushed a commit
that referenced
this pull request
Aug 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks @parthaa for documenting the expected flow with Pulp here: https://partha.fedorapeople.org/CVModuleFilters/
Goal of this PR is achieve feature parity in Pulp3.