Refs #31586 - load common.rake for pulp3 content switchover #9098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in b6532ce we added disable_dynflow to the switchover task, but didn't load the common.rake that defines it.
|
Issues: #31586 |
ekohl
reviewed
Jan 13, 2021
| @@ -1,3 +1,5 @@ | |||
| load "#{Katello::Engine.root}/lib/katello/tasks/common.rake" | |||
|
|
|||
| require File.expand_path("../engine", File.dirname(__FILE__)) | |||
There was a problem hiding this comment.
Unrelated, but I wonder why this isn't:
Suggested change
| require File.expand_path("../engine", File.dirname(__FILE__)) | |
| require File.expand_path("engine", File.dirname(__dir__)) |
There was a problem hiding this comment.
i'm not sure this line is even needed, but lets go ahead and merge this
jlsherrill
approved these changes
Jan 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in b6532ce we added disable_dynflow to the switchover task, but didn't
load the common.rake that defines it.