Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fixes #31644 - check ping 503 retry #9105

Closed
wants to merge 4 commits into from

Conversation

jjeffers
Copy link
Member

@jjeffers jjeffers commented Jan 19, 2021

This adds a simple check for 503 http responses and then retries for a given number of times before failing.

Tested this locally by modifying /etc/httpd/conf.d/05-foreman-ssl.conf:

 <Location "/pulp/api/v3">
    ...
    ProxyPass  http://localhost:8080/
    ProxyPassReverse http://localhost:8080/
   ...
  </Location>

At port 8080 a simple web application returns a 503.

In some situations a pulp3 migration will fail because the environment might include pulp3 services that have started but are not yet serving requests. This change provides a little insurance in that case.

@theforeman-bot
Copy link

Issues: #31644

@jjeffers jjeffers changed the title 31644 check ping 503 retry Fixes #31644 check ping 503 retry Jan 19, 2021
@jjeffers jjeffers changed the title Fixes #31644 check ping 503 retry Fixes #31644 - check ping 503 retry Jan 19, 2021
@jjeffers
Copy link
Member Author

[test katello]

@jjeffers jjeffers changed the title Fixes #31644 - check ping 503 retry [WIP] Fixes #31644 - check ping 503 retry Jan 25, 2021
Base automatically changed from master to main January 28, 2021 17:16
Base automatically changed from main to master January 29, 2021 03:46
@jturel
Copy link
Member

jturel commented Mar 25, 2021

I see this is triaged for 3.18.3 but hasn't moved in a while. Still relevant?

@jjeffers
Copy link
Member Author

I see this is triaged for 3.18.3 but hasn't moved in a while. Still relevant?

@jlsherrill @ehelms was the fix for this merged elsewhere?

@jlsherrill
Copy link
Member

it was an installer/puppet module change. I think we can close this now !

@jjeffers jjeffers closed this Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants