Fixes #32590 - always remove puppet and ostree repos #9372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #32590 |
|
To test this, you would need to:
|
|
[test katello] |
the previous detection of puppet repos did not account for the situation where the user had a content view puppet environment, but no longer had any puppet repos. This now will run the cleanup code regardless
jjeffers
approved these changes
May 26, 2021
There was a problem hiding this comment.
Test these changes per the scenario @jlsherrill described - the puppet repositories were removed and the installer completed without error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the previous detection of puppet repos did not account
for the situation where the user had a content view puppet
environment, but no longer had any puppet repos. This now
will run the cleanup code regardless