Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #33978 - Show content views when deleting environment #9807

Merged
merged 1 commit into from
Nov 29, 2021

Conversation

sjha4
Copy link
Member

@sjha4 sjha4 commented Nov 23, 2021

What are the changes introduced in this pull request?

  1. Adds a confirmation modal on environment delete.
  2. Shows content views tied to environment if any.

Considerations taken when implementing this change?

Inform users there are content views tied to environment for confirmation before delete.
Users are still allowed to delete env and the content view is removed from the environment. However, user is not allowed to delete env tied to a content host. That validation is still in place.

What are the testing steps for this pull request?

Create a CV
Publish and promote it to an env.
Go to env and delete.
You should see a modal like below:
Screenshot from 2021-11-23 07-03-40

@theforeman-bot
Copy link

Issues: #33978

Copy link
Contributor

@Andrewgdewar Andrewgdewar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sjha4 sjha4 merged commit b8ac863 into Katello:master Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants