-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #34182 - fix error message when import attribute is missing #9862
Conversation
Issues: #34182 |
I do wonder why Oooh, it's skipped. Should it not be skipped anymore? We'll find out in #9863 |
Now we're talking! |
Otherwise you get the following error: undefined local variable or method `import_attributes' for #<Katello::Api::V2::RepositoriesController:0x000055ecb351d600> Did you mean? import_attribute Or, fixing that: wrong number of arguments (given 2, expected 1) Instead of e.g. "ostree_repository_name is required"
Right, so I can't enable the controller test w/o offending all the recorded VCR tapes. And I am more in 🎄 than in 📼 mood ;) |
error is during assets precompile, which is unrelated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK for the code change, should we open a new issue so we can more easily backport the issue?
[test katello] |
What are the changes introduced in this pull request?
Corrects error message when there are import attributes missing.
Otherwise you get the following error:
Or, fixing that:
Instead of e.g. "ostree_repository_name is required"
Considerations taken when implementing this change?
None, I just want the error to be correct ;-)
What are the testing steps for this pull request?
Trigger
import_uploads
for an OSTree content w/o settingostree_repository_name