feat(community): add AnnualizedRewards grpc query #1751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pirtleshell
requested review from
DracoLi,
nddeluca,
rhuairahrighairidh,
galxy25,
drklee3 and
evgeniy-scherbina
pirtleshell
force-pushed
the
rp-annualized-staking-reward-endpoint
branch
from
253eca3
to
5c45d89
Compare
nddeluca
reviewed
Oct 23, 2023
x/community/keeper/grpc_query.go
Outdated
| // this module uses sdkmath.LegacyDec in its parameters | ||
| // TODO: remove me after upgrade to cosmos-sdk v50 (LegacyDec is everywhere) | ||
| func convertDecToLegacyDec(in sdk.Dec) sdkmath.LegacyDec { | ||
| return sdkmath.LegacyNewDecFromBigIntWithPrec(in.BigInt(), sdkmath.LegacyPrecision) |
There was a problem hiding this comment.
This should be the sdk.Precision or the precision of the in param
nddeluca
requested changes
Oct 23, 2023
x/community/keeper/rewards.go
Outdated
| // It assumes that staking comes from one of two sources depending on if inflation is enabled or not. | ||
| type StakingRewardCalculator struct { | ||
| TotalSupply sdkmath.Int | ||
| TotalBonded sdkmath.Int |
There was a problem hiding this comment.
These data members aren't used outside of internals, so should be private
nddeluca
approved these changes
Oct 24, 2023
pirtleshell
force-pushed
the
rp-annualized-staking-reward-endpoint
branch
from
712a4e8
to
f6a558a
Compare
mergify bot
pushed a commit
that referenced
this pull request
Oct 24, 2023
* add annualized_reward query proto * use sdkmath.LegacyDec to match RPS param... * add AnnualizedRewards grpc query * add changelog entry * simplify calculation & expand test cases (cherry picked from commit 0efe7f2) # Conflicts: # CHANGELOG.md # client/docs/swagger-ui/swagger.yaml # x/community/keeper/staking.go # x/community/types/expected_keepers.go # x/community/types/query.pb.go
pirtleshell
added a commit
that referenced
this pull request
Oct 25, 2023
…1754) * feat(community): add AnnualizedRewards grpc query (#1751) * add annualized_reward query proto * use sdkmath.LegacyDec to match RPS param... * add AnnualizedRewards grpc query * add changelog entry * simplify calculation & expand test cases (cherry picked from commit 0efe7f2) * fix conflicts, remove community param references * backport update to lint CI * disable internal testnet genesis check * fix initialization order of keepers in app.go --------- Co-authored-by: Robert Pirtle <Astropirtle@gmail.com>
pirtleshell
added a commit
that referenced
this pull request
Oct 25, 2023
…1754) * feat(community): add AnnualizedRewards grpc query (#1751) * add annualized_reward query proto * use sdkmath.LegacyDec to match RPS param... * add AnnualizedRewards grpc query * add changelog entry * simplify calculation & expand test cases (cherry picked from commit 0efe7f2) * fix conflicts, remove community param references * backport update to lint CI * disable internal testnet genesis check * fix initialization order of keepers in app.go --------- Co-authored-by: Robert Pirtle <Astropirtle@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds
x/communityquery for annualized rewards which gives the annualized staking reward rateChecklist