Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix a bug with chat: if two keys are pressed simultaneously, chimera replays the first input instead.
The issue is that Halo stores an array of buffered input (up to 64), but chimera was only ever referencing the first element of the array.
static bool ignore_next_key was a symptom of this, as entering backspace would result in input in the following order:
Since the second input replays the first, every time the user hit backspace chimera would see two special backspace characters, thus requiring that every other backspace chimera saw be dropped.
Therefore, this PR also makes changes to prevent control characters (as determined by
std::iscntrl
) from being inserted intochat_input_buffer
and removes theignore_next_key
adjustment.