Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add riscv Architecture and cfg show address & source code #37

Open
wants to merge 3 commits into
base: development-update-readme
Choose a base branch
from

Conversation

x213212
Copy link

@x213212 x213212 commented Dec 2, 2022

Add riscv Architecture and cfg show address & source code
image

Add riscv Architecture and cfg show address & source code
@lgtm-com
Copy link
Contributor

lgtm-com bot commented Dec 2, 2022

This pull request introduces 4 alerts when merging bee98cc into fe700c3 - view on LGTM.com

new alerts:

  • 2 for Wrong number of arguments in a call
  • 1 for Testing equality to None
  • 1 for Duplication in regular expression character class

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog.

Add tarjan algorithm Detection domator tree find loops

Add experimental color cfg
@x213212
Copy link
Author

x213212 commented Dec 2, 2022

Add tarjan algorithm Detection domator tree find loops
Add experimental color cfg

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Dec 2, 2022

This pull request introduces 17 alerts when merging edf2e26 into fe700c3 - view on LGTM.com

new alerts:

  • 6 for Unused import
  • 5 for Unused local variable
  • 2 for Wrong number of arguments in a call
  • 1 for Testing equality to None
  • 1 for Duplication in regular expression character class
  • 1 for Variable defined multiple times
  • 1 for Nested loops with same variable

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog.

@x213212
Copy link
Author

x213212 commented Dec 2, 2022

python3 -m src.asm2cfg -er -c examples/riscv-huge.asm

Add debug highlight
@lgtm-com
Copy link
Contributor

lgtm-com bot commented Dec 2, 2022

This pull request introduces 17 alerts when merging 86cb96a into fe700c3 - view on LGTM.com

new alerts:

  • 6 for Unused import
  • 5 for Unused local variable
  • 2 for Wrong number of arguments in a call
  • 1 for Testing equality to None
  • 1 for Duplication in regular expression character class
  • 1 for Variable defined multiple times
  • 1 for Nested loops with same variable

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog.

@yugr
Copy link
Collaborator

yugr commented Dec 2, 2022

I suggest to split PR to standalone commits to simplify review.

@Kazhuu
Copy link
Owner

Kazhuu commented Dec 6, 2022

I also checked this PR now and it's indeed quite huge. Could you add them to separate commits or feature per PR? Also file src/asm2cfg/asm2cfg.py is growing in size quite a lot. You're welcome to try split some parts of it like you already done with utils.py. If not then this can be done on later PRs as well. One problem with the splitting is making sure this project still works as a GDB plugin. If I remember correctly there might be some problems with import paths.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants