Issue with Kentico v10.0.13 and WorkflowConsistencyModule.cs #160
Labels
bug
Something isn't working
Comments
|
Looks like your XML got dropped from the comment. Regardless, it sounds like you've got a fix. Would you mind creating a pull request so we can review and pull it in? If you need assistance with that I'm happy to help. |
djjach
pushed a commit
to djjach/KInspector
that referenced
this issue
Jan 9, 2018
Merged
ChristopherJennings
pushed a commit
that referenced
this issue
Apr 19, 2019
ChristopherJennings
added a commit
that referenced
this issue
Apr 29, 2019
* Fixes #156 (#157) * Fixes #158 * Update README.md * Fixes #160 (#162) * Committing support version for Kentico-11 (#165) * Committing support version for Kentico-11 * Updated passwordpolicymoduletests to support V11 * Fix #161 (#168) * Fixes #161 * updated test to testing Fix#161 * Security settings #161 * Fixes 167 (#169) * Fixes #167 * Adds missing line from last commit * Added logic to check for empty string within the IN() query. (#175) * Added logic to check for empty string in the IN() query. * Updated to include an actual record count being returned from the dataset so the tables without a class representation would display properly. * TYPO - Resolve Typo "DON NOT RUN" (#176) * Update README.md * Add/update issue templates DC-399 * Add/update issue/PR templates DC-399 * Add/update issue, PR templates, code of conduct, contributing guide DC-399 * Replace http with https DC-399 * Add a check for CMSEnableCsrfProtection (#181) * Add a check for CMSEnableCsrfProtection * Fix syntax error * Update result set string for CSRF protection and module Comment * Workflow XML parsed using ClassName instead of TableName and covers special cases (#183) * Module refactoring #73 (#184) * Delete Cache items module and related probe files * Delete CMSFile usage check (CMSFileModule.cs) and related sql query file * Remove Newsletters not using email queue (OMNewslettersWithoutQueue.cs) * Remove Old Web Farm Tasks (OldWebFarmTasks.cs) * Delete Site map (SiteMapModule.cs) * Delete Add license key for (LicenseSetupModule.cs) * Merge Click jacking protection check with module Security settings in web.config; Partial Refactor * Merge Flood Protection into Security settings * Merge SSL used for Administrative Interface (SslInAdministrationModule.cs) into Security settings * Delete Password policy settings module; refactor and prune related tests * Remove Event log size module * Validate GlobalAdminSetupModule for K12. Refactor. Add app restart code. * Validate SettingsModule for K12 * Validate and refactor RobotsTxtModule * Validate SiteDomainAliasesSetup for K12 * Validate SitesSetupModule for K12 * Validate Disable enabled SMTP servers for K12 * Validate StagingServersSetupModule for K12 * Validate WebFarmServersSetupModule for K12 * Validate WebPartAnalyzerModule for K12 * Validate User password modules for K12 * Adds event log size and password format checks back in (#185) * Create CODEOWNERS * Rename LICENSE.txt to LICENSE.md * Add/update issue, PR templates, code of conduct, contributing guide DCN-34 - adjusted expectations * Add/update issue, PR templates, code of conduct, contributing guide DCN-34 - adjusted expectations * Page not founds module revisions (#192) * Return DataSet method and SimpleBaseInfo support for other modules * Add Event Last Date column * Attachments by size module revisions (#190) * Return DataSet method and SimpleBaseInfo support for other modules * Extend to list results by site and also take into account attachment variants * Tree node children module revisions (#193) * Return DataSet method and SimpleBaseInfo support for other modules * Altered to show a list of all children - useful if results are close to max * Duplicate page aliases module revisions (#191) * Return DataSet method and SimpleBaseInfo support for other modules * Extended to include CMS_Tree as source of aliases and make it overall easier to read * Column/Field validation module (#194) * New ColumnFieldValidation module to check class fields have a matching database representation and vice-versa Signed-off-by: Pete <peter.cranston@distinction.co.uk> * ColumnFieldValidation: make table names case-insensitive to prevent false negatives * Update README.md * Recommended settings module (#189) * Return DataSet method and SimpleBaseInfo support for other modules * Recommended settings for current site with SQL and helper class/method * Update Kentico.KInspector.Modules.csproj System.Windows.Forms is required for ResXResourceSet (confusingly enough) * Use string comparison for bool check to cover empty values * Normalize ResX path in case of project not in CMS folder * Create migration_template.md * Update migration_template.md * Updates package-lock after npm i
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hey, I believe I found an issue with WorkflowConsistencyModule.cs. On the line 226 there is a XPath Expression which looks like this:
XmlNodeList fields = xml.SelectNodes("/NewDataSet/Table1/*");
However, with K10.0.13 my structure of the document xml is the following:
where XYZ_ABC is the name of my page type. I guess that older versions of Kentico had there just "Table1" and that's why xpath expression worked but now I get workflow inconsistency errors even though document looks fine (fields are there). After updating locally to more general XPath:
XmlNodeList fields = xml.SelectNodes("/NewDataSet//");
The code started to work as I expected (fields in the xml were found) and my workflow consistency issues were gone.
The text was updated successfully, but these errors were encountered: