Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tree node children module revisions #193

Conversation

yuriys-kentico
Copy link
Contributor

Motivation

Changes the results of the module Number of children of TreeNode to list all children instead of just the ones over the recommended maximum. This is useful to see sections that are close to the max, such as for Blog or News sections.

How to test

Configure KInspector to point to a Kentico instance's database and file system.
Run the module Number of children of TreeNode.

Copy link
Contributor

@ChristopherJennings ChristopherJennings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ChristopherJennings ChristopherJennings merged commit 626998c into Kentico:master Feb 28, 2019
ChristopherJennings added a commit that referenced this pull request Apr 29, 2019
* Fixes #156 (#157)

* Fixes #158

* Update README.md

* Fixes #160 (#162)

* Committing support version for Kentico-11 (#165)

* Committing support version for Kentico-11

* Updated passwordpolicymoduletests to support V11

* Fix #161 (#168)

* Fixes #161

* updated test to testing Fix#161

* Security settings #161

* Fixes 167 (#169)

* Fixes #167

* Adds missing line from last commit

* Added logic to check for empty string within the IN() query. (#175)

* Added logic to check for empty string in the IN() query.

* Updated to include an actual record count being returned from the dataset so the tables without a class representation would display properly.

* TYPO - Resolve Typo "DON NOT RUN" (#176)

* Update README.md

* Add/update issue templates

DC-399

* Add/update issue/PR templates

DC-399

* Add/update issue, PR templates, code of conduct, contributing guide

DC-399

* Replace http with https

DC-399

* Add a check for CMSEnableCsrfProtection (#181)

* Add a check for CMSEnableCsrfProtection

* Fix syntax error

* Update result set string for CSRF protection and module Comment

* Workflow XML parsed using ClassName instead of TableName and covers special cases (#183)

* Module refactoring #73 (#184)

* Delete Cache items module and related probe files

* Delete CMSFile usage check (CMSFileModule.cs) and related sql query file

* Remove Newsletters not using email queue (OMNewslettersWithoutQueue.cs)

* Remove Old Web Farm Tasks (OldWebFarmTasks.cs)

* Delete Site map (SiteMapModule.cs)

* Delete Add license key for (LicenseSetupModule.cs)

* Merge Click jacking protection check with module Security settings in web.config; Partial Refactor

* Merge Flood Protection into Security settings

* Merge SSL used for Administrative Interface (SslInAdministrationModule.cs) into Security settings

* Delete Password policy settings module; refactor and prune related tests

* Remove Event log size module

* Validate GlobalAdminSetupModule for K12. Refactor. Add app restart code.

* Validate SettingsModule for K12

* Validate and refactor RobotsTxtModule

* Validate SiteDomainAliasesSetup for K12

* Validate SitesSetupModule for K12

* Validate Disable enabled SMTP servers for K12

* Validate StagingServersSetupModule for K12

* Validate WebFarmServersSetupModule for K12

* Validate WebPartAnalyzerModule for K12

* Validate User password modules for K12

* Adds event log size and password format checks back in (#185)

* Create CODEOWNERS

* Rename LICENSE.txt to LICENSE.md

* Add/update issue, PR templates, code of conduct, contributing guide

DCN-34 - adjusted expectations

* Add/update issue, PR templates, code of conduct, contributing guide

DCN-34 - adjusted expectations

* Page not founds module revisions (#192)

* Return DataSet method and SimpleBaseInfo support for other modules

* Add Event Last Date column

* Attachments by size module revisions (#190)

* Return DataSet method and SimpleBaseInfo support for other modules

* Extend to list results by site and also take into account attachment variants

* Tree node children module revisions (#193)

* Return DataSet method and SimpleBaseInfo support for other modules

* Altered to show a list of all children - useful if results are close to max

* Duplicate page aliases module revisions (#191)

* Return DataSet method and SimpleBaseInfo support for other modules

* Extended to include CMS_Tree as source of aliases and make it overall easier to read

* Column/Field validation module (#194)

* New ColumnFieldValidation module to check class fields have a matching database representation and vice-versa

Signed-off-by: Pete <peter.cranston@distinction.co.uk>

* ColumnFieldValidation: make table names case-insensitive to prevent false negatives

* Update README.md

* Recommended settings module (#189)

* Return DataSet method and SimpleBaseInfo support for other modules

* Recommended settings for current site with SQL and helper class/method

* Update Kentico.KInspector.Modules.csproj

System.Windows.Forms is required for ResXResourceSet (confusingly enough)

* Use string comparison for bool check to cover empty values

* Normalize ResX path in case of project not in CMS folder

* Create migration_template.md

* Update migration_template.md

* Updates package-lock after npm i
@yuriys-kentico yuriys-kentico deleted the TreeNodeChildrenModuleRevisions branch June 24, 2019 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants