Committing support version for Kentico-11 #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@petrsvihlik @ChristopherJennings Any update on this so this. So that we can go ahead an use it. |
|
@sultanwork77 could you please make sure all tests are passing? https://ci.appveyor.com/project/kentico/kinspector/build/1.0.394/tests the CI is failing because of that |
|
Aside from the test that isn't passing and one other small issue with the class definition module (#167), this looks like it is working as essentially the same in v11 as it does in v10. At a minimum, we need the test to be updated to make sure it passes (it's not expecting the versions that are being reported because you added v11). I've created a new issue for the class definition module issue (#167) as this is a minor issue and can be addressed later if needed, but we'd certainly like to address it now if possible. |
|
@petrsvihlik |
|
@ChristopherJennings |
|
Thanks for this PR! @sultanwork77, I'll update #167 with some additional details. If you plan to tackle it or have questions, just make a comment there. |
ChristopherJennings
pushed a commit
that referenced
this pull request
Apr 19, 2019
* Committing support version for Kentico-11 * Updated passwordpolicymoduletests to support V11
ChristopherJennings
added a commit
that referenced
this pull request
Apr 29, 2019
* Fixes #156 (#157) * Fixes #158 * Update README.md * Fixes #160 (#162) * Committing support version for Kentico-11 (#165) * Committing support version for Kentico-11 * Updated passwordpolicymoduletests to support V11 * Fix #161 (#168) * Fixes #161 * updated test to testing Fix#161 * Security settings #161 * Fixes 167 (#169) * Fixes #167 * Adds missing line from last commit * Added logic to check for empty string within the IN() query. (#175) * Added logic to check for empty string in the IN() query. * Updated to include an actual record count being returned from the dataset so the tables without a class representation would display properly. * TYPO - Resolve Typo "DON NOT RUN" (#176) * Update README.md * Add/update issue templates DC-399 * Add/update issue/PR templates DC-399 * Add/update issue, PR templates, code of conduct, contributing guide DC-399 * Replace http with https DC-399 * Add a check for CMSEnableCsrfProtection (#181) * Add a check for CMSEnableCsrfProtection * Fix syntax error * Update result set string for CSRF protection and module Comment * Workflow XML parsed using ClassName instead of TableName and covers special cases (#183) * Module refactoring #73 (#184) * Delete Cache items module and related probe files * Delete CMSFile usage check (CMSFileModule.cs) and related sql query file * Remove Newsletters not using email queue (OMNewslettersWithoutQueue.cs) * Remove Old Web Farm Tasks (OldWebFarmTasks.cs) * Delete Site map (SiteMapModule.cs) * Delete Add license key for (LicenseSetupModule.cs) * Merge Click jacking protection check with module Security settings in web.config; Partial Refactor * Merge Flood Protection into Security settings * Merge SSL used for Administrative Interface (SslInAdministrationModule.cs) into Security settings * Delete Password policy settings module; refactor and prune related tests * Remove Event log size module * Validate GlobalAdminSetupModule for K12. Refactor. Add app restart code. * Validate SettingsModule for K12 * Validate and refactor RobotsTxtModule * Validate SiteDomainAliasesSetup for K12 * Validate SitesSetupModule for K12 * Validate Disable enabled SMTP servers for K12 * Validate StagingServersSetupModule for K12 * Validate WebFarmServersSetupModule for K12 * Validate WebPartAnalyzerModule for K12 * Validate User password modules for K12 * Adds event log size and password format checks back in (#185) * Create CODEOWNERS * Rename LICENSE.txt to LICENSE.md * Add/update issue, PR templates, code of conduct, contributing guide DCN-34 - adjusted expectations * Add/update issue, PR templates, code of conduct, contributing guide DCN-34 - adjusted expectations * Page not founds module revisions (#192) * Return DataSet method and SimpleBaseInfo support for other modules * Add Event Last Date column * Attachments by size module revisions (#190) * Return DataSet method and SimpleBaseInfo support for other modules * Extend to list results by site and also take into account attachment variants * Tree node children module revisions (#193) * Return DataSet method and SimpleBaseInfo support for other modules * Altered to show a list of all children - useful if results are close to max * Duplicate page aliases module revisions (#191) * Return DataSet method and SimpleBaseInfo support for other modules * Extended to include CMS_Tree as source of aliases and make it overall easier to read * Column/Field validation module (#194) * New ColumnFieldValidation module to check class fields have a matching database representation and vice-versa Signed-off-by: Pete <peter.cranston@distinction.co.uk> * ColumnFieldValidation: make table names case-insensitive to prevent false negatives * Update README.md * Recommended settings module (#189) * Return DataSet method and SimpleBaseInfo support for other modules * Recommended settings for current site with SQL and helper class/method * Update Kentico.KInspector.Modules.csproj System.Windows.Forms is required for ResXResourceSet (confusingly enough) * Use string comparison for bool check to cover empty values * Normalize ResX path in case of project not in CMS folder * Create migration_template.md * Update migration_template.md * Updates package-lock after npm i
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I have done is looked through all the modules I could and all the one's that have V10 as their latest Supported Version then I have added to V11 else I have ignored.
The list of modules I did look into are all submitted in the other branch Support_V11
Thanks
Sultan