Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate "Top 25 tables by size (MB)" module to V4 report #241

Closed
6 tasks done
ChristopherJennings opened this issue Apr 25, 2019 · 1 comment
Closed
6 tasks done

Migrate "Top 25 tables by size (MB)" module to V4 report #241

ChristopherJennings opened this issue Apr 25, 2019 · 1 comment
Assignees
@kentico-anthonym
Labels
groomed Well-defined and ready to be worked on help wanted This is an opportunity for anyone to contribute report migration

Comments

@ChristopherJennings
Copy link
Contributor

ChristopherJennings commented Apr 25, 2019 •
edited
Loading

Overview

We should migrate the Top 25 tables by size (MB) module to the new V4 report format.

Definition of done

  • Code and Scripts are ported to KenticoInspector.Reports project in a dedicated folder for the report.
  • Scripts are referenced via constants in a static class.
  • Scripts are refactored to return simple results that are mappable to simple classes.
  • Report logic is covered by unit test for a clean result
  • Report logic is covered by unit tests for all known dirty results
  • Useful, non-specific logic is abstracted to services or helpers.

Note: The Class/Table Validation report (and it's tests) is a good, simple example of the main concepts.

Additional Details

  • New name: Database Table Size Analysis
  • Tags: Health
@ChristopherJennings ChristopherJennings added help wanted This is an opportunity for anyone to contribute groomed Well-defined and ready to be worked on report migration labels Apr 25, 2019
@ChristopherJennings ChristopherJennings added this to the 4.0 milestone Apr 25, 2019
@ChristopherJennings ChristopherJennings mentioned this issue Apr 25, 2019
Open
@kentico-anthonym
Copy link
Member

Reporting for duty.

@kentico-anthonym kentico-anthonym mentioned this issue May 9, 2019
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kentico-anthonym kentico-anthonym

Labels
groomed Well-defined and ready to be worked on help wanted This is an opportunity for anyone to contribute report migration
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ChristopherJennings @Simply007 @kentico-anthonym