Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract ASP.NET-related code to a separate project/NuGet package #117

Closed
2 tasks
JanLenoch opened this issue Jul 24, 2018 · 1 comment
Closed
2 tasks

Extract ASP.NET-related code to a separate project/NuGet package #117

JanLenoch opened this issue Jul 24, 2018 · 1 comment
Labels

Comments

@JanLenoch
Copy link

JanLenoch commented Jul 24, 2018

Motivation

Microsoft.Extensions.Options carries quite a lot of dependencies. In case, the consumer of our SDK uses the it in a non-ASP.NET project, they might be unnecessary.

According to @davidfowl, "Microsoft.Extensions.* is intended for use outside of ASP.NET Core."

Let's wait for the result of the discussion and also the result of the StackOverflow thread before we go any further.

Suggested approach

  • Extract the following code to a separate project KenticoCloud.Delivery.AspNet:
  • Eventually, replace private readonly Dictionary<string, StringValues> _queryParameters with private readonly Dictionary<string, string> _queryParameters to get rid of the Microsoft.Extensions.Primitives reference.
@petrsvihlik
Copy link
Contributor

nobody complained about it ever -> closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants