Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mantineSearchTextInputProps cannot take "data-autofocus" prop as per focus-trap/TextInput #273

Open
1 task done
Xerxes-17 opened this issue Feb 15, 2024 · 0 comments
Open
1 task done
Labels
bug Something isn't working V1 Issue with MRT V1

Comments

@Xerxes-17
Copy link

mantine-react-table version

v1.3.4

react & react-dom versions

v18.2.0

Describe the bug and the steps to reproduce it

mantineSearchTextInputProps is implied in the documentation to accept any props that exist for Mantine TextInput Docs, which should then include the data-autofocus part of focus-traps, for say, a Drawer. It is possible to just put it in anyway, but it does show up as an error.

Object literal may only specify known properties, and '"data-autofocus"' does not exist in type '(Omit<HTMLProps, "data" | "color" | "size" | "type" | "ref" | "label"> & { ref?: MutableRefObject<HTMLInputElement | null> | null | undefined; } & Partial<...>) | ((props: { ...; }) => Omit<...> & ... 1 more ... & Partial<...>)'.ts(2353)
index.d.ts(778, 5): The expected type comes from property 'mantineSearchTextInputProps' which is declared here on type 'MRT_TableOptions'

Minimal, Reproducible Example - (Optional, but Recommended)

    mantineSearchTextInputProps:{
        "data-autofocus" : true // shows as error
    },

Screenshots or Videos (Optional)

Showing that ignoring the TSerror allows it to work.
image

image

Do you intend to try to help solve this bug with your own PR?

No, because I do not know how

Terms

  • I understand that if my bug cannot be reliably reproduced in a debuggable environment, it will probably not be fixed and this issue may even be closed.
@alessandrojcm alessandrojcm added V1 Issue with MRT V1 bug Something isn't working labels Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working V1 Issue with MRT V1
Projects
None yet
Development

No branches or pull requests

2 participants