Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date filtering doesn't work on android #924

Closed
1 task done
chmelevskij opened this issue Jan 9, 2024 · 3 comments · Fixed by #930
Closed
1 task done

Date filtering doesn't work on android #924

chmelevskij opened this issue Jan 9, 2024 · 3 comments · Fixed by #930

Comments

@chmelevskij
Copy link
Contributor

chmelevskij commented Jan 9, 2024

material-react-table version

2.5.0

react & react-dom versions

18.2.0

Describe the bug and the steps to reproduce it

  1. Visit https://2th6tf-3001.csb.app/ on android device.

  2. Find Hire Date column and click it.

  3. Date is filled in with placeholder string, no popup or even keyboard showing up, date picker icon is not visible.

  4. There are no obvious errors or bugs when debugger is connected.

Minimal, Reproducible Example - (Optional, but Recommended)

Codesanbox example from the docs
https://2th6tf-3001.csb.app/

Screenshots or Videos (Optional)

Screenshot_20240109_093320_Chrome

Do you intend to try to help solve this bug with your own PR?

Maybe, I'll investigate and start debugging

Terms

  • I understand that if my bug cannot be reliably reproduced in a debuggable environment, it will probably not be fixed and this issue may even be closed.
@chmelevskij
Copy link
Contributor Author

One more observation, looks like date picker icon is not rendered at all. There is no input adorment added to the field.

Looking at https://mui.com/x/react-date-pickers/date-picker/ sandbox example https://n2nmlm.csb.app/ missing icon is expected, but on the mui-x example, on android, once input is pressed it opens up a date picker
Screenshot_20240109_100025_Chrome

@chmelevskij
Copy link
Contributor Author

Ok, seems that this is even reproducible with responsive mode in chrome.

@chmelevskij
Copy link
Contributor Author

Found the culprit https://github.com/KevinVandy/material-react-table/blob/v2/packages/material-react-table/src/inputs/MRT_FilterTextField.tsx#L356

This seems to prevent the popup on narrow screen sizes. Now the question is if this can be safely removed or will it need some workaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant