Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove SetManifest from boost property trees #108

Merged
merged 2 commits into from
Sep 29, 2018

Conversation

hendrikmuhs
Copy link
Contributor

removes SetManifest(boost:ptree) in favor of SetManifest(std::string), the first wasn't in use, so it is IMHO safe to remove.

relates #80

@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 95.234% when pulling 81c3ba0 on hendrikmuhs:simplify-manifest into b7017e7 on KeyviDev:master.

Copy link
Contributor

@amit-cliqz amit-cliqz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hendrikmuhs hendrikmuhs merged commit 4fcc8d8 into KeyviDev:master Sep 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants