-
Notifications
You must be signed in to change notification settings - Fork 2
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Actually remove reviewers instead of just removing it from the Gerald…
… comment (#37) ## Summary: In the past, if someone commented `#RemoveMe` on a pull request, it would remove them from the Gerald megacomment and prevent Gerald from readding them as reviewers in the future, but it doesn't actually remove them as a reviewer. This PR makes it so that Gerald will actually make a request to remove reviewers that have commented `#RemoveMe`. Issue: WEB-2758 ## Test plan: See (#35), where Kevin B. was requested for review, and after commenting `#RemoveMe`, his review request was removed. Author: yipstanley Reviewers: jeresig Required Reviewers: Approved by: jeresig Checks: ✅ Flow Coverage, ✅ Jest Coverage, ✅ Jest, ✅ Eslint, ✅ autofix, ✅ lint_and_unit, ✅ build_index Pull request URL: #37
- Loading branch information
1 parent
4180f81
commit 7c00a33
Showing
2 changed files
with
38 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters