Actually remove reviewers instead of just removing it from the Gerald comment #37
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
In the past, if someone commented
#RemoveMe
on a pull request, it would remove them from the Gerald megacomment and prevent Gerald from readding them as reviewers in the future, but it doesn't actually remove them as a reviewer. This PR makes it so that Gerald will actually make a request to remove reviewers that have commented#RemoveMe
.Issue: WEB-2758
Test plan:
See (#35), where Kevin B. was requested for review, and after commenting
#RemoveMe
, his review request was removed.