This repository has been archived by the owner on May 11, 2021. It is now read-only.
Interactive time-telling #6362
Closed
Interactive time-telling #6362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // hand = "minute" or "hour" | ||
| // callback return the minute (N/60) the user clicked | ||
| this.watchForClick = function(hand, callback){ | ||
| var coord = $("#pie").offset(); |
There was a problem hiding this comment.
hmm, shouldn't have #pie referenced in the library. I'm not sure how to get the parent element of this.graph ... KhanUtil provides currentGraph but not something along the lines of currentGraphWrapper
|
Closing this since I just merged the other pull request for this exercise (#8913). |
|
I understand, that one eventually got farther. But it's kind of a bummer, because no one ever commented on it or provided the advice I requested. |
|
I understand, and I'm really sorry about that. Everyone's been really busy and by the time we had a chance to look, the other one was further along. I hope this doesn't discourage you from contributing in the future. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey --
I picked up interactive time telling from the Trello board and decided it would be fun. I refactored AnalogClock to add this capability.
This one is still in draft status. Todos:
<head>as I've done acceptable? I've tried to maintain a strict separation between what should be library code and what should be specific to this problem..hidden-instructionclass). Any conventions I missed on this?Give it a whirl, I'm curious what you think!
(btw, this is in conjunction with the MIT founders journey class...)