New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New exercise: Interactive telling time #8913

Merged
merged 42 commits into from Jan 3, 2012

Conversation

Projects
None yet
4 participants
@stephjang
Contributor

stephjang commented Dec 18, 2011

Trello bug: "Telling time, interactive" in "Queued up"
Feedback much appreciated!

CHANGED

telling_time_interactive.html

  • "Set the clock to 3:45". User moves clock hands accordingly.
  • Hints might need some editing from a more experienced hint-writer.

time.js

  • Copied and extended analogClock() from graphie-helpers.js to a more customizable addAnalogClock() function (modeled after addMovablePoint()) inside time.js
  • NOTE: the functions coordToDegrees() and degreesToCoord() may belong in other packages. Any ideas where?
  • NOTE: roundToNearest() belongs in math.js. See below.

interactive.js

  • Added a snapPoints option to movablePoint.constraints.fixedDistance to allow snapping around a circle (fixedDistance restricts the point's motion to a circle). snapPoints is the number of points that can be snapped to around the circle.
  • NOTE: to implement this functionality, there is a bit of redundancy with functions in angles.js and time.js, but this might be unavoidable since interactive.js may be used without the others.

angle.js

  • Added toDegrees() function

NO CHANGE CURRENTLY, BUT SHOULD CHANGE

telling_time.html & telling_time_0.5.html

  • NOTE: should be updated using new time.js package (if accepted)

math.js

  • NOTE: I tried to add roundToNearest() (currently in time.js) to math.js but for some reason I couldn't get it to work. Something about how math.js is compiled? Is it a special file compared to the others?

graphie-helpers.js

  • NOTE: if time.js is accepted and telling_time.html & telling_time_0.5.html are updated, we should remove the analogClock() function from here.
@stephjang

This comment has been minimized.

Show comment
Hide comment
@stephjang

stephjang Dec 18, 2011

Contributor

Oh dang, I just saw that someone else attempted this already: #6362. But it seems they didn't finish...

Contributor

stephjang commented Dec 18, 2011

Oh dang, I just saw that someone else attempted this already: #6362. But it seems they didn't finish...

@stephjang

This comment has been minimized.

Show comment
Hide comment
@stephjang

stephjang Dec 18, 2011

Contributor

Whoops, I didn't mean to commit the changes to unit_circle.html or to graphie-helpers.js...

Contributor

stephjang commented Dec 18, 2011

Whoops, I didn't mean to commit the changes to unit_circle.html or to graphie-helpers.js...

@mwahl

This comment has been minimized.

Show comment
Hide comment
@mwahl

mwahl Dec 19, 2011

Contributor

Nice exercise @stchangg!! Great addition to the time setting series. Will be mentioning a few minor suggestions - will take a deeper look in the next few days.

Contributor

mwahl commented Dec 19, 2011

Nice exercise @stchangg!! Great addition to the time setting series. Will be mentioning a few minor suggestions - will take a deeper look in the next few days.

@mwahl

View changes

Show outdated Hide outdated exercises/telling_time_interactive.html
@mwahl

View changes

Show outdated Hide outdated exercises/telling_time_interactive.html
@mwahl

View changes

Show outdated Hide outdated exercises/telling_time_interactive.html
@mwahl

View changes

Show outdated Hide outdated exercises/telling_time_interactive.html
@beneater

View changes

Show outdated Hide outdated exercises/telling_time_interactive.html
@beneater

View changes

Show outdated Hide outdated exercises/telling_time_interactive.html
@beneater

View changes

Show outdated Hide outdated exercises/telling_time_interactive.html
@beneater

View changes

Show outdated Hide outdated exercises/telling_time_interactive.html
@stephjang

This comment has been minimized.

Show comment
Hide comment
@stephjang

stephjang Dec 28, 2011

Contributor

I modified the hints and felt that the plural() function from word-problems.js could make them a bit smoother. However, will this affect load time/performance, since this exercise includes so many modules now? The full list is: math math-format graphie interactive angles time word-problems

Contributor

stephjang commented Dec 28, 2011

I modified the hints and felt that the plural() function from word-problems.js could make them a bit smoother. However, will this affect load time/performance, since this exercise includes so many modules now? The full list is: math math-format graphie interactive angles time word-problems

@stephjang

This comment has been minimized.

Show comment
Hide comment
@stephjang

stephjang Dec 29, 2011

Contributor

I'm pretty sure I made all of the latest requested changes. Let me know if there's anything left!

Contributor

stephjang commented Dec 29, 2011

I'm pretty sure I made all of the latest requested changes. Let me know if there's anything left!

@stephjang

This comment has been minimized.

Show comment
Hide comment
@stephjang

stephjang Jan 1, 2012

Contributor

@beneater I refactored the other time exercises and removed the old time code from graphie-helpers. :)

Contributor

stephjang commented Jan 1, 2012

@beneater I refactored the other time exercises and removed the old time code from graphie-helpers. :)

@beneater

View changes

Show outdated Hide outdated utils/time.js
@beneater

View changes

Show outdated Hide outdated utils/time.js
@beneater

View changes

Show outdated Hide outdated exercises/telling_time_interactive.html

Stephanie H. Chang added some commits Jan 3, 2012

@beneater

This comment has been minimized.

Show comment
Hide comment
@beneater

beneater Jan 3, 2012

Member

Awesome! This is a really great exercise!
Looking forward to seeing many more :)

As I mentioned before, it might be another week or so before it goes live since Matt's out of town :(

Member

beneater commented Jan 3, 2012

Awesome! This is a really great exercise!
Looking forward to seeing many more :)

As I mentioned before, it might be another week or so before it goes live since Matt's out of town :(

beneater added a commit that referenced this pull request Jan 3, 2012

Merge pull request #8913 from stchangg/interactive-telling-time
New exercise: Interactive telling time

@beneater beneater merged commit 4cde86f into Khan:master Jan 3, 2012

@beneater beneater referenced this pull request Jan 3, 2012

Closed

Interactive time-telling #6362

@mwahl

This comment has been minimized.

Show comment
Hide comment
@mwahl

mwahl Jan 3, 2012

Contributor

Thanks @stchangg for rocking this - very slick. Will let you know when we push live later this week/weekend!

Contributor

mwahl commented Jan 3, 2012

Thanks @stchangg for rocking this - very slick. Will let you know when we push live later this week/weekend!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment