This repository has been archived by the owner on May 11, 2021. It is now read-only.
Elimination 0.5: Anchored index to control problem type, changed hint colors #8061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -15,7 +15,7 @@ | |||
| <div class="vars"> | |||
| <var id="X">randRange( 1, 10 )</var> | |||
| <var id="Y" data-ensure="X !== Y">randRange( 1, 10 )</var> | |||
| <var id="INDEX">randRange( 0, 3 )</var> | |||
| <var id="INDEX">0</var> | |||
There was a problem hiding this comment.
Did you mean to change this?
There was a problem hiding this comment.
Changing back in the merged file.
There was a problem hiding this comment.
Yeah I did, that variable controls which variable, x or y, is going to be eliminated. In Elimination 1, we show a mix of all 4 types, but here we're just showing one where no multiplication needs to be done.
There was a problem hiding this comment.
gotcha - thx scott. per ben's comment - we'll want to clean up later on (just remove the index). for now let's get the fix live.
mwahl
added a commit
that referenced
this pull request
Dec 7, 2011
Elimination 0.5: Anchored index to control problem type, changed hint colors
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the following problem, the hint shown after the variable is eliminated doesn't match up with the original equations:
http://sandcastle.khanacademy.org/media/castles/Khan:master/exercises/systems_of_equations_with_elimination_0.5.html?seed=122&debug
Using the "Index" should fix that. Also, switched blue and green.