Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcoded parameter count for getImage #353

Merged
merged 1 commit into from
Jul 10, 2015
Merged

Hardcoded parameter count for getImage #353

merged 1 commit into from
Jul 10, 2015

Conversation

bytorbrynden
Copy link
Contributor

While unable to replicate the issue, this is a minor change to [attempt to] fix #339.

I've included all the rebuilt files in this PR.

@kevinbarabash
Copy link
Contributor

Cool. Why the file mode change in live-editor.audio.js?

@bytorbrynden
Copy link
Contributor Author

...not sure, I didn't notice that. I know something in the gulp build failed (something with getSound, which I didn't touch); would that have anything to do with it?

@kevinbarabash
Copy link
Contributor

Can you post the failure?

@bytorbrynden
Copy link
Contributor Author

Sure thing!

image

@codeHusky
Copy link

Don't really know how the build system works really, but does this have anything to do with it?
#352

@bytorbrynden
Copy link
Contributor Author

I don't believe it does @MikaalSky; that issue did show itself when I was doing an initial build, before making any changes, but hasn't done it since.

You'll notice, the gulp build didn't exit; it finished. The only thing that went "wrong", was the two tests that ran out of time.

@kevinbarabash
Copy link
Contributor

Those errors are "okay". They only show up when running the tests on the console. It has something to do phantomjs. I'll try and get those fixed this weekend, don't worry about them. @MikaalSky that's actually a different issue which I'm also going to try and fix this weekend. @Gigabyte-Giant I think that changing the permissions to 644 is the right thing to do so I'm going to merge this.

kevinbarabash added a commit that referenced this pull request Jul 10, 2015
Hardcoded parameter count for getImage
@kevinbarabash kevinbarabash merged commit 2d8dc39 into Khan:master Jul 10, 2015
@kevinbarabash
Copy link
Contributor

@Gigabyte-Giant thanks for the pull request.

@bytorbrynden
Copy link
Contributor Author

Always happy to help!

Will be trying to get my head into the live-editor more and more over the next few days/weeks/months; as it's all really interesting work.

:)

@kevinbarabash
Copy link
Contributor

Glad to hear that. I find it really interesting too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getImage() reports that it takes 0 parameters, in some browsers
3 participants