-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hardcoded parameter count for getImage #353
Conversation
Cool. Why the file mode change in live-editor.audio.js? |
...not sure, I didn't notice that. I know something in the gulp build failed (something with |
Can you post the failure? |
Don't really know how the build system works really, but does this have anything to do with it? |
I don't believe it does @MikaalSky; that issue did show itself when I was doing an initial build, before making any changes, but hasn't done it since. You'll notice, the gulp build didn't exit; it finished. The only thing that went "wrong", was the two tests that ran out of time. |
Those errors are "okay". They only show up when running the tests on the console. It has something to do phantomjs. I'll try and get those fixed this weekend, don't worry about them. @MikaalSky that's actually a different issue which I'm also going to try and fix this weekend. @Gigabyte-Giant I think that changing the permissions to 644 is the right thing to do so I'm going to merge this. |
Hardcoded parameter count for getImage
@Gigabyte-Giant thanks for the pull request. |
Always happy to help! Will be trying to get my head into the live-editor more and more over the next few days/weeks/months; as it's all really interesting work. :) |
Glad to hear that. I find it really interesting too! |
While unable to replicate the issue, this is a minor change to [attempt to] fix #339.
I've included all the rebuilt files in this PR.