-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make errors for using advanced JS features friendlier #493
Conversation
@@ -58488,7 +58488,9 @@ var warnings = { | |||
W101: i18n._("Line is too long."), | |||
W102: i18n._("Trailing whitespace."), | |||
W103: i18n._("The '{a}' property is deprecated."), | |||
W104: i18n._("'{a}' is only available in JavaScript 1.7."), | |||
W104: i18n._("It looks like you're trying to use '{a}'. '{a}' is a " + | |||
"JavaScript 1.7 feature and is not currently supported in the live " + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you change "live editor" to "this editor" or "this environment"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do!
@pamelafox I've made the edit you suggested. Let me know if there's anything else I should do. |
@@ -58503,7 +58505,8 @@ var warnings = { | |||
W117: i18n._("\"{a}\" is not defined. Make sure you're spelling it correctly " + | |||
"and that you declared it."), | |||
W118: i18n._("'{a}' is only available in Mozilla JavaScript extensions (use moz option)."), | |||
W119: i18n._("'{a}' is only available in ES6 (use esnext option)."), | |||
W119: i18n._("'{a}' is only available in ES6 which is not supported by " + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change to environment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops. Sorry bout that. I do not have access to my desktop currently but once I do I'll fix this and let you know. Sorry for the goof-up.
IMO, Khan shouldn't bar ES6 features at all. Specially something as old as |
It's not a question of barring ES6 features, it's a question of supporting them. We want all CS programs to run cross browser which means that we'd have to babel to compile them. We'd also have to update the linter (or switch to eslint if we want to support all ES6). |
|
@pamelafox Sorry for that goof-up I've fixed it now and everything should be ready. Very sorry for that. |
While we're dropping IE9 support as of Jan 2016, we'll still be support IE10 for a while.
They also make using classes less intimidating for beginner programmers. |
@JavaScriptFTW instead of merging master can you rebase your changes on to master? |
@kevinbarabash It's rebased now. It should be ready for merging once the tests are complete. |
@kevinbarabash I believe that I've changed the message according to your suggestion. |
Excellent. LGTM. |
Make errors for using advanced JS features friendlier
@JavaScriptFTW thanks for the pull request. |
Seems like not even MS wants to support those very old browsers anymore after January 12, 2016: :-D For now IE11 survives. But I bet it's not gonna take too long for MS to support Edge only... @_@ |
This pull request fixes #492 by editing the jshint messages for using ES7 and ES6 features to be worded in a more friendly and helpful way.
Minor Changes
external/jshint/jshint.js
If any editing is required please let me know.
Thank you for your time.