Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bookmarklet): Support 'file' protocol #132

Merged
merged 1 commit into from
Mar 15, 2019
Merged

fix(bookmarklet): Support 'file' protocol #132

merged 1 commit into from
Mar 15, 2019

Conversation

ccarpita
Copy link
Contributor

@ccarpita ccarpita commented Oct 8, 2018 •
edited
Loading

The bookmarklet currently uses a protocol-independent URL to load the source, which means that pages viewed locally (file:///) will attempt to also load the library from the file tree, rather than the CDN. There is no compelling reason to load the asset on http vs https, even when viewing a plain-http page, and thus the protocol should be set to https explicitly.

This change fixes #130

  • CLA Signed
  • Tested on file:/// page
  • Tested on https:// page
  • Tested on http:// page

@ccarpita
fix(bookmarklet): Support 'file' protocol
a7e441b 
The bookmarklet currently uses a protocol-independent URL to load the source, which means that pages viewed locally (`file:///`) will attempt to also load the library from the file tree, rather than the CDN. There is no compelling reason to load the asset on http vs https, even when viewing a plain-http page, and thus the protocol should be set to https explicitly.

Fixes jdan#130
@khanbot
Copy link

khanbot commented Oct 8, 2018

CLA signature looks good 👍

somewhatabstract
somewhatabstract approved these changes Mar 15, 2019
View reviewed changes
Copy link
Contributor

@somewhatabstract somewhatabstract left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution, @ccarpita! Great stuff!

@somewhatabstract somewhatabstract merged commit 4fbad07 into jdan:gh-pages Mar 15, 2019
@ericrallen ericrallen mentioned this pull request Mar 21, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@somewhatabstract somewhatabstract somewhatabstract approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ccarpita @khanbot @somewhatabstract