Ensure compute encoding state is marked dirty for non-dispatch commands. #1922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The same compute encoder is used across dispatches and other commands, which may override compute state, and end up breaking subsequent dispatches. - Mark compute encoding state dirty when following commands, which use Metal compute encoders, are issued: - vkCmdCopyBuffer() - vkCmdClearColorImage() - vkCmdClearDepthStencilImage() - vkCmdFillBuffer() - vkCmdCopyQueryPoolResults() - MVKCommandEncoder move marking compute state dirty from endCurrentMetalEncoding() to getMTLComputeEncoder(). - For efficiency, don't prematurely force end of query copy compute encoder used on renderpass end, in case compute dispatches follow. - Update MoltenVK to 1.2.5 (unrelated).
cdavis5e
approved these changes
May 26, 2023
mbechard
added a commit
to mbechard/MoltenVK
that referenced
this pull request
Jul 19, 2023
Needed to complete fix for KhronosGroup#1874 We can't wait until getMTLComputeEncoder() is called to dirty the state, because this call will be avoided by dirty checks themselves. Those checks are comparing against leftover and now incorrect state since the previous encoder has already ended. It needs to be dirtied on encoder end.
mbechard
added a commit
to mbechard/MoltenVK
that referenced
this pull request
Jul 19, 2023
Needed to complete fix for KhronosGroup#1874 We can't wait until getMTLComputeEncoder() is called to dirty the state, because this call will be avoided by dirty checks themselves. Those checks are comparing against leftover and now incorrect state since the previous encoder has already ended. It needs to be dirtied on encoder end.
billhollings
added a commit
that referenced
this pull request
Jul 19, 2023
Fix regression caused by #1922
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The same compute encoder is used across dispatches and other commands, which may override compute state, and end up breaking subsequent dispatches.
Mark compute encoding state dirty when following commands, which use Metal compute encoders, are issued:
vkCmdCopyBuffer()vkCmdClearColorImage()vkCmdClearDepthStencilImage()vkCmdFillBuffer()vkCmdCopyQueryPoolResults()MVKCommandEncodermove marking compute state dirty fromendCurrentMetalEncoding()togetMTLComputeEncoder().For efficiency, don't prematurely force end of query copy compute encoder used on renderpass end, in case compute dispatches follow.
Update MoltenVK to 1.2.5 (unrelated).
Fixes issue #1874