MVKPixelFormats: Handle the B4G4R4A4 format.
#2074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hang on--this introduced a bunch of failures with this format... |
Handle it similarly to the `A4R4B4G4` and `A4B4G4R4` formats, with a swizzle. Vulkan requires support for this format. Fixes the following tests: * `dEQP-VK.api.info.format_properties.b4g4r4a4_unorm_pack16`. * `dEQP-VK.texture.explicit_lod.2d.formats.b4g4r4a4*`
cdavis5e
force-pushed
the
b4g4r4a4-unorm
branch
from
d8af516
to
552e5c0
Compare
|
OK, I think I'm satisfied that I fixed all the failures I added. |
billhollings
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle it similarly to the
A4R4B4G4andA4B4G4R4formats, with a swizzle. Vulkan requires support for this format.Fixes the following tests:
dEQP-VK.api.info.format_properties.b4g4r4a4_unorm_pack16.dEQP-VK.texture.explicit_lod.2d.formats.b4g4r4a4*