-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specification for cl_khr_extended_versioning #218
Specification for cl_khr_extended_versioning #218
Conversation
Here's a first attempt at getting the specification for
|
I have a few style opinions:
A few other comments:
In general though, this all looks very good. Thanks! |
Picking this up again.
Agree, and this change has now been done in another PR.
I think it's useful info to answer the "what-were-they-thinking-when-they-designed-this type questions". I take your point though and I agree this may end up taking quite a bit of space in the spec. Given that we maintain the extension spec as a separate document, I'm not sure it's too big a deal. It seems to be working fine for Vulkan (these are in the appendix where extensions are described).
I disagree with this. I find it very useful to be able to know what companies/people were behind specific Vulkan extensions for example.
Yup, makes sense. I'll remove that.
Will do.
I think we should always do it. It's our best bet to guard against enum conflicts. |
7f4bd4e
to
0c841b8
Compare
0c841b8
to
4e80c99
Compare
@bashbaug I think this is ready for another round of review when you have time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I didn't come back to this sooner. One real open question here for me.
4e80c99
to
f39df02
Compare
@alycm Thanks for the review. I've rebased it and addressed your comments. |
Signed-off-by: Kevin Petit <kevin.petit@arm.com> Change-Id: Ibe017baa7b8f0a24f9294aaabae4efeaadb43055
f39df02
to
d3d0c32
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please have one last look at some of the style comments I left previously - #218 (comment)?
Some of these are admittedly subjective, but this PR is doing things a bit inconsistently with the ways extensions have been documented in the past and I would like to be sure we are purposefully deviating.
I've also left a few specific comments inline. Thanks!
|
||
`cl_khr_extended_versioning` | ||
|
||
==== Contributors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See previous comment regarding extension metadata like contributors, issues, etc. We haven't included this information in other KHR extensions. Is this a practice we want to continue into the future?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think my position hasn't changed here and I think we should do that for all extensions.
Change-Id: I44ef74894f3f0a77b226e4e123d3b917ec4518eb
Change-Id: If3aab0711f3645936bb74dec4c0fd32773551c1f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, all my issues are resolved.
Let's see if we can merge this one in today's teleconference.
Merging as discussed in the November 10th teleconference. |
Signed-off-by: Kevin Petit kevin.petit@arm.com