registry: spec: Update XR_MNDX_egl_enable's version to 2 #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
utzcoz
force-pushed
the
update-XR_MNDX_egl_enable-to-v2
branch
from
53a268b
to
5f381ba
Compare
|
IMO, this updating is necessary, but I don't know whether you need it. cc @rpavlik for reviewing. |
utzcoz
force-pushed
the
update-XR_MNDX_egl_enable-to-v2
branch
from
5f381ba
to
747a735
Compare
utzcoz
changed the title
|
An issue (number 2157) has been filed to correspond to this pull request in the internal Khronos GitLab (Khronos members only: KHR:openxr/openxr#2157 ), to facilitate working group processes. This GitHub pull request will continue to be the main site of discussion. |
rpavlik-bot
added
the
synced to gitlab
|
Friendly ping @rpavlik for reviewing. |
|
Thanks, yeah, that is probably a good idea. |
rpavlik
force-pushed
the
update-XR_MNDX_egl_enable-to-v2
branch
from
747a735
to
e842f5a
Compare
rpavlik
approved these changes
Jan 3, 2024
From 1.0.29, XR_MNDX_egl_enable changed the type of getProcAddress from PFNEGLGETPROCADDRESSPROC to new added PFN_xrEglGetProcAddressMNDX. When I tried to bump to this version for Monado, it caused compiling error for Android NDK armeabi-v7a because new function type has extra __attribute__ definition. From this experience, the 1.0.29's change changed the extension APIs, and we might need to bump the version of this extension to 2 to let Runtime and apps know it. doc: Add documentation fragment Signed-off-by: utzcoz <utzcoz@outlook.com>
rpavlik
force-pushed
the
update-XR_MNDX_egl_enable-to-v2
branch
from
e842f5a
to
d23492a
Compare
|
Arg, I merged to the wrong branch. Pretend it didn't happen, and that I merged to staging as I should. 🤦♀️ |
|
@rpavlik No problem. Thanks for your reviewing and merging it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From 1.0.29, XR_MNDX_egl_enable changed the type of getProcAddress from PFNEGLGETPROCADDRESSPROC to new added PFN_xrEglGetProcAddressMNDX. When I tried to bump to this version for Monado, it caused compiling error for Android NDK armeabi-v7a because new function type has extra attribute definition. From this experience, the 1.0.29's change changed the extension APIs, and we might need to bump the version of this extension to 2 to let Runtime and apps know it.