-
Notifications
You must be signed in to change notification settings - Fork 549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validator disallows Float16 capability even when the necessary extension is present #1375
Comments
The validator simply ignores this extension since it's not in the grammar, so there are no rules for it. I could hardcode this particular case somewhere, but I think it's more of a question for @dneto0. |
It turns out that specifying the "SPV_AMD_gpu_shader_half_float" extension does not necessarily mean Float16 capability should be enabled. Nothing needs to be done. Sorry for the confusion. |
Ok, so there is still some work that needs to be done. If
But we should not get this validation error if the "SPV_AMD_gpu_shader_half_float" extension is specified. |
conclusion of my talk with @dneto0 was that we should tell the validator about this extension and the fact that it enables 16bit floats by adding it to the |
just let me join the discussion and say that it is strange as with SPIRV-tools from Vulkan SDK 1.0.68 all works OK (EDIT: I mean SPIR-V code with Float16 cap+ SPV_AMD_.. ext):
|
Fixes KhronosGroup#1375 Hardcoded float16 feature enabling if extension SPV_AMD_gpu_shader_half_float is present.
Fixes KhronosGroup#1375 Hardcoded float16 feature enabling if extension SPV_AMD_gpu_shader_half_float is present.
Fixes KhronosGroup#1375 Hardcoded float16 feature enabling if extension SPV_AMD_gpu_shader_half_float is present.
I am trying to validate a SPIR-V file that includes usages of 16-bit float.
The validator complains that:
However, my SPIR-V contains
OpExtension "SPV_AMD_gpu_shader_half_float"
which is the extension that enables this capability. Attached is the SPIR-V source.float16.txt
The text was updated successfully, but these errors were encountered: