Remove duplicate and buggy implementation of getWord(). #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -62,6 +62,27 @@ TEST(GetWord, Simple) { | |||
| EXPECT_EQ("abc", AssemblyContext(AutoText("abc\n"), nullptr).getWord()); | |||
| } | |||
|
|
|||
| TEST(GetWord, MultipleWords) { | |||
There was a problem hiding this comment.
This tests more than just multiple words -- it tests various forms of word break. I'd split it into multiple tests with separate responsibilities.
There was a problem hiding this comment.
Reasonable. Removed different whitespaces since they are tested in the previous test.
antiagainst
force-pushed
the
invalid-opcodename
branch
from
15407fa
to
a8e494f
Compare
We already have a better getWord() implemented as a free function. Use that instead of creating another one.
antiagainst
force-pushed
the
invalid-opcodename
branch
from
a8e494f
to
702ae29
Compare
| case '\r': | ||
| case '\n': | ||
| case ' ': | ||
| return std::string(text_->str, text_->str + index); |
There was a problem hiding this comment.
This is the direct reason why #126 behaves like that. We should return string(text_->str + current_position_.index, ...).
There was a problem hiding this comment.
But I figure it's better to use the more robust version of getWord() anyway.
|
A better way to fix this in done via #155. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already have a better
getWord()implemented as a free function.Use that instead of creating another one.
Addresses #152.