Aliasing through a union member is valid. #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -33,7 +33,9 @@ enum { | |||
| I32_ENDIAN_BIG = 0x00010203ul, | |||
| }; | |||
|
|
|||
| // TODO(dneto): This relies on undefined behaviour. Fix that. | |||
| // This constant value allows the detection of the host machine's endianness. | |||
| // Accessing it the "value" member is valid due to C++11 section 3.10 | |||
There was a problem hiding this comment.
Accessing it through the "value" member
dneto0
force-pushed
the
alias-via-union
branch
2 times, most recently
from
a18b6e4
to
5ab8a03
Compare
Take back my previous TODO.
dneto0
force-pushed
the
alias-via-union
branch
from
5ab8a03
to
c9e0845
Compare
|
+2 |
dgkoch
pushed a commit
to dgkoch/SPIRV-Tools
that referenced
this pull request
Nov 21, 2018
…ng-frontend Add "Shaderc over Glslang" as a front end
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take back my previous TODO.