Update external headers. #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now use the headers published at https://www.khronos.org/registry/spir-v/api/1.0/.
| @@ -50,12 +50,12 @@ | |||
|
|
|||
| typedef unsigned int SpvId; | |||
|
|
|||
| #define SPV_VERSION 100 | |||
| #define SPV_REVISION 1 | |||
| #define SPV_VERSION 10000 | |||
There was a problem hiding this comment.
Gah. Should file an issue upstream to indicate this likely should be a hex value ?
I believe the "1" part of it should be mapping to the upper 16 bits of the generator word.
There was a problem hiding this comment.
Hmm. Looking at the version word in the SPIR-V spec, it seems this should be hex and occupy the entire 32-bits of the version word.
There was a problem hiding this comment.
Right... It's interesting to see that SpvVersion (L57, which we actually use) is defined correctly.
|
This change is good, but I think upstream is wrong. :-) |
This was referenced Nov 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now use the headers published at
https://www.khronos.org/registry/spir-v/api/1.0/.