Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow OpTypeBool in UniformConstant #5237

Merged
merged 1 commit into from
Jun 6, 2023
Merged

Allow OpTypeBool in UniformConstant #5237

merged 1 commit into from
Jun 6, 2023

Conversation

alan-baker
Copy link
Contributor

See KhronosGroup/SPIRV-Registry#72

  • OpenGL allowed uniforms to be declared with boolean types, but the validator was overly strict in disallowing it

@alan-baker
Allow OpTypeBool in UniformConstant
39d5c91 
See KhronosGroup/SPIRV-Registry#72

* OpenGL allowed uniforms to be declared with boolean types, but the
  validator was overly strict in disallowing it
@alan-baker alan-baker requested a review from dneto0 May 24, 2023 18:56
@alan-baker alan-baker added this to In progress in Validator via automation May 24, 2023
@alan-baker alan-baker self-assigned this May 24, 2023
@alan-baker
Copy link
Contributor Author

I plan to double check this with the SPIR WG in the 2023-05-31 call.

dneto0
dneto0 approved these changes May 24, 2023
View reviewed changes
Copy link
Collaborator

@dneto0 dneto0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Let's wait to merge this until confirmation of the resolution at Khronos.

@alan-baker alan-baker merged commit 59b4feb into KhronosGroup:main Jun 6, 2023
21 of 22 checks passed
Validator automation moved this from In progress to Done Jun 6, 2023
@alan-baker alan-baker deleted the uniform-constant-bool branch June 6, 2023 22:05
@rdb rdb mentioned this pull request Jun 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dneto0 dneto0 dneto0 approved these changes

Assignees

@alan-baker alan-baker

Labels
component:validation
Projects
Validator
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alan-baker @dneto0