properly handle the load and store cache control operand types #5664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-perron
approved these changes
Jul 19, 2024
|
Please add a test, and rebase the PR. There are conflicts now. |
|
I fixed the merge conflict and I added a test, which fails before my change and passes after my change. @s-perron please let me know if this is what you had in mind - thanks! I think the CI-macos-clang-release failure is unrelated to my changes. |
s-perron
approved these changes
Jul 22, 2024
Without handling these operand types, disassembling a SPIR-V module that uses the cache control extension produces an invalid operand type error.
s-perron
force-pushed
the
spirv-dis-cache-controls
branch
from
d643a86
to
bf00b3f
Compare
|
The CI-windows-VS2019-debug failure is not because of this PR. It should pass when we rerun it but I cannot get it to rebuild. I rebased and did a force push. Hopefully the test will now pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without handling these operand types, disassembling a SPIR-V module that uses the cache control extension produces an invalid operand type error: "error: 33: Internal error: Unhandled operand type: 81".