Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about test cases distribution between FULL and non-FULL modes #214

Open
AlexeySachkov opened this issue Nov 8, 2021 · 1 comment

Comments

@AlexeySachkov
Copy link
Contributor

Hi folks,

We have been working on support for SYCL 2020 specialization constants in our SYCL implementation at intel/llvm and we have realized that unless you switch into FULL mode, you are missing a huge piece of data type coverage for test_specialization_constants. In particular, we do not test vec and marray data types in non-FULL mode at all in those tests.

Therefore, I was wondering if there are some guideline about how CTS should be written to ensure meaningful coverage in both FULL and non-FULL modes? Do we need to explicitly document the distribution in test plans?

@psalz
Copy link
Member

psalz commented Nov 12, 2021

We discussed this in the working group and the consensus seems to be that its likely not possible to come up with general guidelines for what types should and should not be included in the non-full conformance mode. The problem is that the sets of types that trigger different behavior vary between both SYCL features and SYCL implementations, so there's likely no one-size-fits-all answer here. Instead we need to rely on code review and implementer feedback to come up with a good tradeoff on a case-by-case basis.

That being said, the types that are to be tested in non-full conformance mode should probably be listed in test plans. We can definitely add a note for this to the test plans README.

steffenlarsen pushed a commit to steffenlarsen/SYCL-CTS that referenced this issue Dec 6, 2022
…perty_list-test-plan

Add test plan for compile-time property_list
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants